Re: [PATCH v2 bpf-next 05/16] selftests/bpf: Test for syscall program type

On Mon, Apr 26, 2021 at 7:43 PM Alexei Starovoitov
[off-list ref] wrote:

On Mon, Apr 26, 2021 at 10:02:59AM -0700, Andrii Nakryiko wrote:

quoted

quoted

+/* Copyright (c) 2021 Facebook */
+#include <linux/stddef.h>
+#include <linux/bpf.h>
+#include <bpf/bpf_helpers.h>
+#include <bpf/bpf_tracing.h>
+#include <../../tools/include/linux/filter.h>

with TOOLSINCDIR shouldn't this be just <linux/fiter.h>?

sadly no. There is uapi/linux/filter.h that gets included first.
And changing the order of -Is brings the whole set of other issues.
I couldn't come up with anything better unfortunately.

Then let's at least drop TOOLSINCDIR for now, if it's not really used?