Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi
From: David Miller <davem@davemloft.net>
Date: 2021-04-12 23:15:06
Also in:
virtualization
From: David Miller <davem@davemloft.net>
Date: 2021-04-12 23:15:06
Also in:
virtualization
From: "Michael S. Tsirkin" <mst@redhat.com> Date: Mon, 12 Apr 2021 18:33:45 -0400
On Mon, Apr 12, 2021 at 06:08:21PM -0400, Michael S. Tsirkin wrote:quoted
OK I started looking at this again. My idea is simple. A. disable callbacks before we try to drain skbs B. actually do disable callbacks even with event idx To make B not regress, we need to C. detect the common case of disable after event triggering and skip the write then. I added a new event_triggered flag for that. Completely untested - but then I could not see the warnings either. Would be very much interested to know whether this patch helps resolve the sruprious interrupt problem at all ... Signed-off-by: Michael S. Tsirkin <mst@redhat.com>Hmm a slightly cleaner alternative is to clear the flag when enabling interrupts ... I wonder which cacheline it's best to use for this. Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Please make a fresh new submission if you want to use this approach, thanks.