Re: [Patch bpf-next v2 5/9] udp: add ->read_sock() and ->sendmsg_locked() to ipv6

On Tue, Mar 2, 2021 at 8:23 AM Lorenz Bauer [off-list ref] wrote:

On Tue, 2 Mar 2021 at 02:38, Cong Wang [off-list ref] wrote:

quoted

diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index 54f24b1d4f65..717c543aaec3 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c

@@ -1831,6 +1831,7 @@ int udp_read_sock(struct sock *sk, read_descriptor_t *desc,

        return copied;
 }
+EXPORT_SYMBOL(udp_read_sock);

Should this be in the previous commit?

No, exporting this symbol is unnecessary until a module starts to
use it, which is IPv6 module in this patch. So, it is perfectly fine to
export it here.

Thanks.