Re: [RFC PATCH v2 net-next 14/16] net: dsa: don't set skb->offload_fwd_mark when not offloading the bridge
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-03-19 10:50:05
Also in:
linux-omap, lkml
On Fri, Mar 19, 2021 at 05:29:12PM +0800, DENG Qingfang wrote:
On Fri, Mar 19, 2021 at 5:06 PM Vladimir Oltean [off-list ref] wrote:quoted
This is a good point actually, which I thought about, but did not give a lot of importance to for the moment. Either we go full steam ahead with assisted learning on the CPU port for everybody, and we selectively learn the addresses relevant to the bridging funciton only, or we do what you say, but then it will be a little bit more complicated IMO, and have hardware dependencies, which isn't as nice.Are skb->offload_fwd_mark and source DSA switch kept in dsa_slave_xmit? I think SA learning should be bypassed iff skb->offload_fwd_mark == 1 and source DSA switch == destination DSA switch.
Why would you even want to look at the source net device for forwarding? I'd say that if dp->bridge_dev is NULL in the xmit function, you certainly want to bypass address learning if you can. Maybe also for link-local traffic.