Re: [PATCH v7 net-next 02/15] dts: marvell: add CM3 SRAM memory to cp115 ethernet device tree
From: Marcin Wojtas <hidden>
Date: 2021-02-04 19:01:54
Also in:
lkml
Hi, wt., 2 lut 2021 o 09:17 [off-list ref] napisał(a):
quoted hunk ↗ jump to hunk
From: Konstantin Porotchkin <redacted> CM3 SRAM address space would be used for Flow Control configuration. Signed-off-by: Stefan Chulski <redacted> Signed-off-by: Konstantin Porotchkin <redacted> --- arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi index 9dcf16b..359cf42 100644 --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
The commit message mentions CP115, but the patch updates both CP110 and CP115 - please update one of those (either message or the patch), so that it is consistent. Thanks, Marcin
quoted hunk ↗ jump to hunk
@@ -69,6 +69,8 @@ status = "disabled"; dma-coherent; + cm3-mem = <&CP11X_LABEL(cm3_sram)>; + CP11X_LABEL(eth0): eth0 { interrupts = <39 IRQ_TYPE_LEVEL_HIGH>, <43 IRQ_TYPE_LEVEL_HIGH>,@@ -211,6 +213,14 @@ }; }; + CP11X_LABEL(cm3_sram): cm3@220000 { + compatible = "mmio-sram"; + reg = <0x220000 0x800>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0x220000 0x800>; + }; + CP11X_LABEL(rtc): rtc@284000 { compatible = "marvell,armada-8k-rtc"; reg = <0x284000 0x20>, <0x284080 0x24>; --1.9.1