[PATCH bpf-next 00/12] Various cleanups/fixes for AF_XDP selftests · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 01/12] selftests/bpf: remove a lot of ifobject casting · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 02/12] selftests/bpf: remove unused enums · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 03/12] selftests/bpf: fix style warnings · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 04/12] selftests/bpf: remove memory leak · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 05/12] selftests/bpf: improve readability of xdpxceiver/worker_pkt_validate() · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 06/12] selftests/bpf: remove casting by introduce local variable · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 12/12] selftests/bpf: avoid useless void *-casts · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 10/12] selftests/bpf: avoid heap allocation · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 09/12] selftests/bpf: define local variables at the beginning of a block · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 11/12] selftests/bpf: consistent malloc/calloc usage · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 08/12] selftests/bpf: change type from void * to struct generic_data * · Björn Töpel <hidden> · 2021-01-22
[PATCH bpf-next 07/12] selftests/bpf: change type from void * to struct ifaceconfigobj * · Björn Töpel <hidden> · 2021-01-22
Re: [PATCH bpf-next 00/12] Various cleanups/fixes for AF_XDP selftests · patchwork-bot+netdevbpf@kernel.org · 2021-01-25

[PATCH bpf-next 04/12] selftests/bpf: remove memory leak

STALE2085d LANDED

From: Björn Töpel <hidden>
Date: 2021-01-22 15:49:58
Also in: bpf
Subsystem: bpf [general] (safe dynamic programs and tools), bpf [selftests] (test runners & infrastructure), kernel selftest framework, the rest, xdp (express data path) · Maintainers: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Eduard Zingerman, Kumar Kartikeya Dwivedi, Shuah Khan, Shuah Khan, Linus Torvalds, David S. Miller, Jakub Kicinski, Jesper Dangaard Brouer, John Fastabend

Landed in mainline as 4896d7e37ea5 on 2021-01-25.

From: Björn Töpel <redacted>

The allocated entry is immediately overwritten by an assignment. Fix
that.

Signed-off-by: Björn Töpel <redacted>
---
 tools/testing/selftests/bpf/xdpxceiver.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/testing/selftests/bpf/xdpxceiver.c
index 77d1bda37afa..9f40d310805a 100644
--- a/tools/testing/selftests/bpf/xdpxceiver.c
+++ b/tools/testing/selftests/bpf/xdpxceiver.c

@@ -728,7 +728,6 @@ static void worker_pkt_validate(void)
 	u32 payloadseqnum = -2;
 
 	while (1) {
-		pkt_node_rx_q = malloc(sizeof(struct pkt));
 		pkt_node_rx_q = TAILQ_LAST(&head, head_s);
 		if (!pkt_node_rx_q)
 			break;

-- 
2.27.0

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help