Thread (12 messages) 12 messages, 4 authors, 2021-01-07

Re: [PATCH 2/4] dt-bindings: net: Add bindings for Qualcomm QCA807x

flat view

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-01-03 17:00:44
Also in: linux-arm-msm, linux-devicetree, lkml

quoted
quoted
+  qcom,tx-driver-strength:
+    description: PSGMII/QSGMII TX driver strength control.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]
Please use the actual values here, and have the driver convert to the
value poked into the register. So the property would be
qcom,tx-driver-strength-mv and it would have the value 220 for
example.
The LED binding has properties for specifying the current already. And 
it's max current which is the h/w property where as anything less is 
just software configuration (IOW, doesn't belong in DT).
Hi Rob

My understanding of this is it is the drive strength of the SERDES
line. Nothing to do with LEDs. The description needs improving.

      Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help