Re: [PATCH 2/4] dt-bindings: net: Add bindings for Qualcomm QCA807x
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-12-23 00:57:23
Also in:
linux-arm-msm, linux-devicetree, lkml
quoted hunk ↗ jump to hunk
+ gpio-controller: true + "#gpio-cells": + const: 2 + + qcom,single-led-1000: + description: | + If present, then dedicated 1000 Mbit will light up for 1000Base-T. + This is a workround for boards with a single LED instead of two. + type: boolean + + qcom,single-led-100: + description: | + If present, then dedicated 1000 Mbit will light up for 100Base-TX. + This is a workround for boards with a single LED instead of two. + type: boolean + + qcom,single-led-10: + description: | + If present, then dedicated 1000 Mbit will light up for 10Base-Te. + This is a workround for boards with a single LED instead of two. + type: boolean
Sorry, but no. Please look at the work being done for allow PHY LEDs to be controlled via the LED subsystem.
quoted hunk ↗ jump to hunk
+ qcom,tx-driver-strength: + description: PSGMII/QSGMII TX driver strength control. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]
Please use the actual values here, and have the driver convert to the value poked into the register. So the property would be qcom,tx-driver-strength-mv and it would have the value 220 for example.
quoted hunk ↗ jump to hunk
+ + qcom,control-dac: + description: Analog MDI driver amplitude and bias current. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1, 2, 3, 4, 5, 6, 7]
Make here.
Andrew