Thread (36 messages) flat view 36 messages, 4 authors, 2021-01-15

Re: [PATCH v3 net-next 02/10] net: mscc: ocelot: add ops for decoding watermark threshold and occupancy

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-11 19:11:30

On Mon, 11 Jan 2021 18:53:21 +0200 Vladimir Oltean wrote:
On Sat, Jan 09, 2021 at 05:20:46PM -0800, Jakub Kicinski wrote:
quoted
On Fri,  8 Jan 2021 19:59:42 +0200 Vladimir Oltean wrote:  
quoted
+	*inuse = (val & GENMASK(23, 12)) >> 12;  
FWIW FIELD_GET()  
Do you mind if I don't use it? I don't feel that:
	*inuse = FIELD_GET(GENMASK(23, 12), val);
looks any better.
Not at all, your call.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help