On Wed, Dec 09, 2020 at 03:23:40PM +0100, Andrew Lunn wrote:

On Wed, Dec 09, 2020 at 12:53:26PM +0200, Vladimir Oltean wrote:

quoted

On Wed, Dec 09, 2020 at 09:37:39AM +0100, Tobias Waldekranz wrote:

quoted

I will remove `struct dsa_lag` in v4.

Ok, thanks.
It would be nice if you could also make .port_lag_leave return an int code.

I've not looked at the code, but how can it fail, other than something
probably fatal with communication with the hardware. And what should
the rest of the stack do? Recreate what is just destroyed? And does
that really work?

What can fail is memory allocation, which other drivers might need to do
when they rebalance the remaining ports in the LAG.