Re: [RFC PATCH net-next 1/6] net: implement threaded-able napi poll loop support
From: Paolo Abeni <pabeni@redhat.com>
Date: 2020-09-28 08:45:45
From: Paolo Abeni <pabeni@redhat.com>
Date: 2020-09-28 08:45:45
Hello, On Sat, 2020-09-26 at 16:22 +0200, Hannes Frederic Sowa wrote:
On Sat, Sep 26, 2020, at 01:50, Wei Wang wrote:quoted
I took a look at the current "threadirqs" implementation. From my understanding, the kthread used there is to handle irq from the driver, and needs driver-specific thread_fn to be used. It is not as generic as in the napi layer where a common napi_poll() related function could be used as the thread handler. Or did I misunderstand your point?Based on my memories: We had napi_schedule & co being invoked inside the threads
I just looked at the code - I really forgot most details. The above is correct...
without touching any driver code when we specified threadirqs. But this would need a double check.
... but still that code needed some per device driver modification: the irq subsystem handled the switch to/from threaded mode, and needed some callback, provided from the device driver, to notify the network code about the change (specifically, to mark the threaded status inside the relevant napi struct). Cheers, Paolo