Re: [PATCH V6 20/20] net: ks8851: Drop define debug and pr_fmt()

On 5/17/20 4:55 AM, Joe Perches wrote:

On Sun, 2020-05-17 at 04:47 +0200, Marek Vasut wrote:

quoted

On 5/17/20 4:37 AM, Joe Perches wrote:

quoted

On Sun, 2020-05-17 at 04:28 +0200, Marek Vasut wrote:

quoted

On 5/17/20 4:01 AM, Joe Perches wrote:

quoted

On Sun, 2020-05-17 at 02:33 +0200, Marek Vasut wrote:

quoted

Drop those debug statements from both drivers. They were there since
at least 2011 and enabled by default, but that's likely wrong.

[]

quoted

diff --git a/drivers/net/ethernet/micrel/ks8851_par.c b/drivers/net/ethernet/micrel/ks8851_par.c

[]

quoted

-#define DEBUG

Dropping the #define DEBUG lines will cause a behavior
change for the netdev/netif_dbg uses as these messages
will no longer be output by default.

Is that a problem ?

Dunno.  I don't use nor debug these drivers.

I don't use those debug messages either, so it's not a problem for me.

Just mention it in the changelog please.

Or let's just drop this patch for now.

I am still waiting for a clear direction on the indirect accessors.