Re: [PATCH V6 18/20] net: ks8851: Implement Parallel bus operations

On Sun, 17 May 2020 02:33:52 +0200 Marek Vasut wrote:

Implement accessors for KS8851-16MLL/MLLI/MLLU parallel bus variant of
the KS8851. This is based off the ks8851_mll.c , which is a driver for
exactly the same hardware, however the ks8851.c code is much higher
quality. Hence, this patch pulls out the relevant information from the
ks8851_mll.c on how to access the bus, but uses the common ks8851.c
code. To make this patch reviewable, instead of rewriting ks8851_mll.c,
ks8851_mll.c is removed in a separate subsequent patch.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: David S. Miller <davem@davemloft.net>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Petr Stetiar <redacted>
Cc: YueHaibing <redacted>

Please test build with W=1

drivers/net/ethernet/micrel/ks8851_par.c:64:13: warning: context imbalance in 'ks8851_lock_par' - wrong count at exit
drivers/net/ethernet/micrel/ks8851_par.c:78:13: warning: context imbalance in 'ks8851_unlock_par' - unexpected unlock