Re: [PATCH V6 16/20] net: ks8851: Implement register, FIFO, lock accessor callbacks

On 5/18/20 6:34 PM, Jakub Kicinski wrote:

On Sun, 17 May 2020 02:33:50 +0200 Marek Vasut wrote:

quoted

The register and FIFO accessors are bus specific, so is locking.
Implement callbacks so that each variant of the KS8851 can implement
matching accessors and locking, and use the rest of the common code.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: David S. Miller <davem@davemloft.net>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Petr Stetiar <redacted>
Cc: YueHaibing <redacted>

drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member '____cacheline_aligned' not described in 'ks8851_net'
drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'tx_space' not described in 'ks8851_net'
drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'lock' not described in 'ks8851_net'
drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'unlock' not described in 'ks8851_net'
drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rdreg16' not described in 'ks8851_net'
drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'wrreg16' not described in 'ks8851_net'
drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rdfifo' not described in 'ks8851_net'
drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'wrfifo' not described in 'ks8851_net'
drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'start_xmit' not described in 'ks8851_net'
drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'rx_skb' not described in 'ks8851_net'
drivers/net/ethernet/micrel/ks8851.c:138: warning: Function parameter or member 'flush_tx_work' not described in 'ks8851_net'
drivers/net/ethernet/micrel/ks8851.c:163: warning: Function parameter or member 'spi_xfer1' not described in 'ks8851_net_spi'
drivers/net/ethernet/micrel/ks8851.c:163: warning: Function parameter or member 'spi_xfer2' not described in 'ks8851_net_spi'
drivers/net/ethernet/micrel/ks8851.c:561: warning: Function parameter or member 'ks' not described in 'ks8851_rx_skb_spi'
drivers/net/ethernet/micrel/ks8851.c:570: warning: Function parameter or member 'ks' not described in 'ks8851_rx_skb'

A lot of those were there already before this series and they are in
fact fixed by this series. The result builds clean with W=1 .