Re: [PATCH v3 1/5] net: phy: Add support for microchip SMI0 MDIO bus
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-05-09 19:25:55
quoted
- mdiobb_cmd(ctrl, MDIO_WRITE, phy, reg); + mdiobb_cmd(ctrl, ctrl->op_c22_write, phy, reg);There are other users of the mdio-bitbang.c file which I believe you are going to break here because they will not initialize op_c22_write or op_c22_read, and thus they will be using 0, instead of MDIO_READ and MDIO_WRITE. I believe you need something like the patch attached.
Ah, totally missed that: https://elixir.bootlin.com/linux/latest/source/arch/powerpc/platforms/82xx/ep8248e.c#L98 https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/8390/ax88796.c#L444 https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c#L103 https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/renesas/ravb_main.c#L165 https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/renesas/sh_eth.c#L1257 Andrew