Re: [PATCH 01/14] net: ks8851: Factor out spi->dev in probe()/remove()
From: Lukas Wunner <lukas@wunner.de>
Date: 2020-03-24 06:52:19
On Tue, Mar 24, 2020 at 12:42:50AM +0100, Marek Vasut wrote:
- gpio = of_get_named_gpio_flags(spi->dev.of_node, "reset-gpios",
+ gpio = of_get_named_gpio_flags(dev->of_node, "reset-gpios",
0, NULL);
if (gpio == -EPROBE_DEFER) {
ret = gpio;Nit: It would be nice to unwrap the line since it is shorter than 80 chars even with "0, NULL);" appended.
quoted hunk ↗ jump to hunk
@@ -1456,12 +1457,12 @@ static int ks8851_probe(struct spi_device *spi) ret = regulator_enable(ks->vdd_io); if (ret) { - dev_err(&spi->dev, "regulator vdd_io enable fail: %d\n", + dev_err(dev, "regulator vdd_io enable fail: %d\n", ret); goto err_reg_io; }
Same here.
quoted hunk ↗ jump to hunk
@@ -1469,7 +1470,7 @@ static int ks8851_probe(struct spi_device *spi) ret = regulator_enable(ks->vdd_reg); if (ret) { - dev_err(&spi->dev, "regulator vdd enable fail: %d\n", + dev_err(dev, "regulator vdd enable fail: %d\n", ret); goto err_reg; }
Same. Thanks, Lukas