Re: [PATCH 06/14] net: ks8851: Remove ks8851_rdreg32()
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-03-24 01:30:47
quoted hunk ↗ jump to hunk
@@ -527,9 +507,8 @@ static void ks8851_rx_pkts(struct ks8851_net *ks) */ for (; rxfc != 0; rxfc--) { - rxh = ks8851_rdreg32(ks, KS_RXFHSR); - rxstat = rxh & 0xffff; - rxlen = (rxh >> 16) & 0xfff; + rxstat = ks8851_rdreg16(ks, KS_RXFHSR); + rxlen = ks8851_rdreg16(ks, KS_RXFHBCR) & RXFHBCR_CNT_MASK;
Hi Marek Is there anything in the datasheet about these registers? Does reading them clear an interrupt etc? A 32bit read is i assume one SPI transaction, where as this is now two transactions, so no longer atomic. Andrew