Thread (51 messages) 51 messages, 5 authors, 2020-03-04

Re: [patch net-next v2 01/12] flow_offload: Introduce offload of HW stats type

From: Edward Cree <hidden>
Date: 2020-03-02 16:29:48
Also in: netfilter-devel

On 02/03/2020 13:20, Pablo Neira Ayuso wrote:
2) explicit counter action, in this case the user specifies explicitly
   that it needs a counter in a given position of the rule. This
   counter might come before or after the actual action.
But the existing API can already do this, with a gact pipe.  Plus, Jiri's
 new API will allow specifying a counter on any action (rather than only,
 implicitly, those which have .stats_update()) should that prove to be
 necessary.

I really think the 'explicit counter action' is a solution in search of a
 problem, let's not add random orthogonality violations.  (Equally if the
 counter action had been there first, I'd be against adding counters to
 the other actions.)

-ed
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help