Re: [patch net-next v2 08/12] flow_offload: introduce "immediate" HW stats type and allow it in mlxsw
From: Jiri Pirko <jiri@resnulli.us>
Date: 2020-03-02 13:59:32
Mon, Mar 02, 2020 at 02:23:42PM CET, pablo@netfilter.org wrote:
On Sun, Mar 01, 2020 at 09:47:16AM +0100, Jiri Pirko wrote:quoted
Sat, Feb 29, 2020 at 08:32:18PM CET, pablo@netfilter.org wrote:quoted
On Fri, Feb 28, 2020 at 06:25:01PM +0100, Jiri Pirko wrote: [...]quoted
@@ -31,7 +31,8 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp, act = flow_action_first_entry_get(flow_action); switch (act->hw_stats_type) { - case FLOW_ACTION_HW_STATS_TYPE_ANY: + case FLOW_ACTION_HW_STATS_TYPE_ANY: /* fall-through */ + case FLOW_ACTION_HW_STATS_TYPE_IMMEDIATE:This TYPE_ANY mean that driver picks the counter type for you?Driver pick any counter, yes.quoted
Otherwise, users will not have a way to know how to interpret what kind of counter this is.User does not care in this case.OK. When listing back the counters, will the user get what counter type the driver has selected?
User will get back exactly what he passed.