Re: [patch net-next v2 03/12] flow_offload: check for basic action hw stats type
From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-02-28 19:41:00
On Fri, 28 Feb 2020 18:24:56 +0100 Jiri Pirko wrote:
quoted hunk ↗ jump to hunk
@@ -299,6 +300,9 @@ static int bnxt_tc_parse_actions(struct bnxt *bp, return -EINVAL; } + if (!flow_action_basic_hw_stats_types_check(flow_action, extack)) + return -EOPNOTSUPP;
Could we have this helper take one stat type? To let drivers pass the stat type they support? At some point we should come up with a way to express the limitations at callback registration time so we don't need to add checks like this to all the drivers. On the TODO list it goes :)
flow_action_for_each(i, act, flow_action) {
switch (act->id) {
case FLOW_ACTION_DROP: