Re: [PATCH v2 net-next/devicetree 4/5] arm64: dts: fsl: ls1028a: add node for Felix switch

Hi Michael,

On Sat, 22 Feb 2020 at 13:38, Michael Walle [off-list ref] wrote:

Hi,

quoted

+
+                     enetc_port2: ethernet@0,2 {
+                             compatible = "fsl,enetc";
+                             reg = <0x000200 0 0 0 0>;
+                             phy-mode = "gmii";

Can we disable this port by default in this dtsi? As mentioned in the other
mail, I'd prefer to have all ports disabled because it doesn't make sense
to have this port while having all the external ports disabled.

Ok. What would you want to happen with the "ethernet" property? Do you
want the board dts to set that too?

quoted

+                                     /* Internal port with DSA tagging */
+                                     mscc_felix_port4: port@4 {
+                                             reg = <4>;
+                                             phy-mode = "internal";
+                                             ethernet = <&enetc_port2>;

Likewise, I'd prefer to have this disabled.

Ok.

quoted

+                     enetc_port3: ethernet@0,6 {
+                             compatible = "fsl,enetc";
+                             reg = <0x000600 0 0 0 0>;
+                             status = "disabled";
+                             phy-mode = "gmii";

shouldn't the status be after the phy-mode property?

Why?

-michael

Regards,
-Vladimir