Thread (46 messages) 46 messages, 8 authors, 2021-04-26

Re: [PATCH net 2/9] r8152: reset flow control patch when linking on for RTL8153B

From: Joe Perches <joe@perches.com>
Date: 2020-01-21 13:02:28
Also in: linux-usb, lkml

On Tue, 2020-01-21 at 13:54 +0100, David Miller wrote:
From: Hayes Wang <redacted>
Date: Tue, 21 Jan 2020 20:40:28 +0800
quoted
When linking ON, the patch of flow control has to be reset. This
makes sure the patch works normally.
[]
quoted
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
[]
quoted
@@ -2857,6 +2857,7 @@ static void r8153_set_rx_early_size(struct r8152 *tp)
 
 static int rtl8153_enable(struct r8152 *tp)
 {
+     u32 ocp_data;
      if (test_bit(RTL8152_UNPLUG, &tp->flags))
              return -ENODEV;
 
Please put an empty line after the local variable declarations.
Local scoping is generally better.

Perhaps declare ocp_data inside the if branch
where it's used.  

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help