Re: [PATCH v3 14/17] octeontx2-pf: Add basic ethtool support

On Fri, Jan 17, 2020 at 7:03 AM Jakub Kicinski [off-list ref] wrote:

On Fri, 17 Jan 2020 01:17:30 +0530, sunil.kovvuri@gmail.com wrote:

quoted

+#define DRV_NAME     "octeontx2-nicpf"
+#define DRV_VERSION  "1.0"

quoted

+     strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+     strlcpy(info->version, DRV_VERSION, sizeof(info->version));

We generally discourage the user of DRV_VERSION these days and suggest
to return the kernel version here. With backports and heavily patched
distro kernels this number quickly becomes counter-informative.

Thanks for the changes to the stats!

Okay, will remove the version info.

Thanks,
Sunil.