Thread (23 messages) flat view 23 messages, 2 authors, 2020-01-17

Re: [PATCH v3 14/17] octeontx2-pf: Add basic ethtool support

From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-01-17 01:33:26

On Fri, 17 Jan 2020 01:17:30 +0530, sunil.kovvuri@gmail.com wrote:
+#define DRV_NAME	"octeontx2-nicpf"
+#define DRV_VERSION	"1.0"
+	strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+	strlcpy(info->version, DRV_VERSION, sizeof(info->version));
We generally discourage the user of DRV_VERSION these days and suggest
to return the kernel version here. With backports and heavily patched
distro kernels this number quickly becomes counter-informative.

Thanks for the changes to the stats!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help