Re: [PATCH v3 15/17] octeontx2-pf: ethtool RSS config support
From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-01-17 01:34:57
On Fri, 17 Jan 2020 01:17:31 +0530, sunil.kovvuri@gmail.com wrote:
+static int otx2_set_rss_hash_opts(struct otx2_nic *pfvf,
+ struct ethtool_rxnfc *nfc)
+{
+ struct otx2_rss_info *rss = &pfvf->hw.rss_info;
+ u32 rxh_l4 = RXH_L4_B_0_1 | RXH_L4_B_2_3;
+ u32 rss_cfg = rss->flowkey_cfg;
+
+ if (!rss->enable)
+ netdev_err(pfvf->netdev, "RSS is disabled, cmd ignored\n");Why not return an error here like you do in otx2_set_rxfh()?
+ /* Mimimum is IPv4 and IPv6, SIP/DIP */ + if (!(nfc->data & RXH_IP_SRC) || !(nfc->data & RXH_IP_DST)) + return -EINVAL;