Re: [PATCH v3 01/12] Documentation: dt: wireless: update wl1251 for sdio
From: Ulf Hansson <hidden>
Date: 2019-11-14 14:11:50
Also in:
linux-arm-kernel, linux-devicetree, linux-mmc, linux-omap, linux-wireless, lkml
On Thu, 7 Nov 2019 at 11:32, H. Nikolaus Schaller [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The standard method for sdio devices connected to an sdio interface is to define them as a child node like we can see with wlcore. Signed-off-by: H. Nikolaus Schaller <redacted> Acked-by: Kalle Valo <redacted> --- .../bindings/net/wireless/ti,wl1251.txt | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+)diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt index bb2fcde6f7ff..f38950560982 100644 --- a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt@@ -35,3 +35,29 @@ Examples: ti,power-gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */ }; }; + +&mmc3 { + vmmc-supply = <&wlan_en>; + + bus-width = <4>; + non-removable; + ti,non-removable; + cap-power-off-card; + + pinctrl-names = "default"; + pinctrl-0 = <&mmc3_pins>; + + #address-cells = <1>; + #size-cells = <0>; + + wlan: wifi@1 { + compatible = "ti,wl1251"; + + reg = <1>; + + interrupt-parent = <&gpio1>; + interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* GPIO_21 */ + + ti,wl1251-has-eeprom; + }; +};
One minor thing, the "ti,power-gpio" is not required anymore, as it's not needed for the SDIO case for pandora. Please move it to an option section. Kind regards Uffe