Re: [PATCH v5 net-next 04/12] net: ethernet: ti: cpsw: move set of common functions in cpsw_priv

From
Grygorii Strashko <grygorii.strashko@ti.com>
Date
2019-11-01 16:56:20
Also in
linux-devicetree, linux-omap, lkml
Reply to
Andrew Lunn, 2019-10-25

On 25/10/2019 16:01, Andrew Lunn wrote:
On Thu, Oct 24, 2019 at 01:09:06PM +0300, Grygorii Strashko wrote:
quoted
As a preparatory patch to add support for a switchdev based cpsw driver,
move common functions to cpsw-priv.c so that they can be used across both
drivers.
Hi Grygorii

Bike shedding, but it seems odd to move common code into a private
file. How common is the current code in cpsw-common.c?
cpsw-common.c is used between cpsw and davinci_emac.c and, as of now, contains
only code to retrieve MAC addr from eFuse regs.
cpsw_priv.x were added intentionally as code moved to these files only used
by ald and new CPSW drivers. This also allows to avoid build/link issues.

-- 
Best regards,
grygorii
Thread (38 messages) 38 messages, 5 authors, last reply 2019-11-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help