Re: [PATCH v5 net-next 04/12] net: ethernet: ti: cpsw: move set of common functions in cpsw_priv

From
Andrew Lunn <andrew@lunn.ch>
Date
2019-10-25 13:01:34
Also in
linux-devicetree, linux-omap, lkml
Reply to
Grygorii Strashko, 2019-10-24
On Thu, Oct 24, 2019 at 01:09:06PM +0300, Grygorii Strashko wrote:
As a preparatory patch to add support for a switchdev based cpsw driver,
move common functions to cpsw-priv.c so that they can be used across both
drivers.
Hi Grygorii

Bike shedding, but it seems odd to move common code into a private
file. How common is the current code in cpsw-common.c?

      Andrew
Thread (38 messages) 38 messages, 5 authors, last reply 2019-11-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help