On Thu, Oct 31, 2019 at 10:31 AM Toke Høiland-Jørgensen [off-list ref] wrote:

Andrii Nakryiko [off-list ref] writes:

quoted

[...]

quoted

        return err;

@@ -4131,17 +4205,24 @@ int bpf_object__unpin_maps(struct bpf_object *obj, const char *path)
                return -ENOENT;

        bpf_object__for_each_map(map, obj) {
+               char *pin_path = NULL;
                char buf[PATH_MAX];

you can call buf as pin_path and get rid of extra pointer?

The idea here is to end up with bpf_map__unpin(map, NULL) if path is
unset. GCC complains if I reassign a static array pointer, so don't
think I can actually get rid of this?

oh, right, it's nullable pointer, then you do need buf and pin_path,
never mind. I keep forgetting this NULL semantics for pin/unpin :)

-Toke