Thread (17 messages) flat view 17 messages, 2 authors, 2019-10-31

Re: [PATCH bpf-next v4 3/5] libbpf: Move directory creation into _pin() functions

From: Andrii Nakryiko <hidden>
Date: 2019-10-31 17:27:25
Also in: bpf

On Tue, Oct 29, 2019 at 12:39 PM Toke Høiland-Jørgensen [off-list ref] wrote:
From: Toke Høiland-Jørgensen <redacted>

The existing pin_*() functions all try to create the parent directory
before pinning. Move this check into the per-object _pin() functions
instead. This ensures consistent behaviour when auto-pinning is
added (which doesn't go through the top-level pin_maps() function), at the
cost of a few more calls to mkdir().

Signed-off-by: Toke Høiland-Jørgensen <redacted>
---
Makes sense, thanks.

Acked-by: Andrii Nakryiko <redacted>
 tools/lib/bpf/libbpf.c |   61 +++++++++++++++++++++++++++---------------------
 1 file changed, 34 insertions(+), 27 deletions(-)
[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help