Re: [PATCH v6 4/4] net: phy: realtek: Add LED configuration support for RTL8211E

On Mon 2019-08-19 02:37:57, Andrew Lunn wrote:

quoted

Yes, I believe the integration is neccessary. Using same binding is
neccessary for that, but not sufficient. For example, we need
compatible trigger names, too.

Hi Pavel

Please could you explain what you mean by compatible trigger names?

Well, you attempted to put trigger names in device tree. That means
those names should work w.r.t. LED subsystem, too.

quoted

So... I'd really like to see proper integration is possible before we
merge this.

Please let me turn that around. What do you see as being impossible at
the moment? What do we need to convince you about?

That locking requirements are compatible, that triggers you invented
can be implemented by LED subsystem, ...

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html