Re: [PATCH v6 4/4] net: phy: realtek: Add LED configuration support for RTL8211E
From: Andrew Lunn <andrew@lunn.ch>
Date: 2019-08-13 20:14:17
Also in:
linux-devicetree, lkml
+static int rtl8211e_config_led(struct phy_device *phydev, int led,
+ struct phy_led_config *cfg)
+{
+ u16 lacr_bits = 0, lcr_bits = 0;
+ int oldpage, ret;
+You should probably check that led is 0 or 1. Otherwise this looks good. Andrew