Re: [PATCH 08/16] mips: prefer __section from compiler_attributes.h
From: Paul Burton <hidden>
Date: 2019-08-15 09:38:59
Also in:
bpf, linux-mips, lkml
Hi Nick, On Mon, Aug 12, 2019 at 02:50:41PM -0700, Nick Desaulniers wrote:
Reported-by: Sedat Dilek <redacted> Suggested-by: Josh Poimboeuf <redacted> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
It would be good to add a commit message, even if it's just a line repeating the subject & preferably describing the motivation.
quoted hunk ↗ jump to hunk
--- arch/mips/include/asm/cache.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/mips/include/asm/cache.h b/arch/mips/include/asm/cache.h index 8b14c2706aa5..af2d943580ee 100644 --- a/arch/mips/include/asm/cache.h +++ b/arch/mips/include/asm/cache.h@@ -14,6 +14,6 @@ #define L1_CACHE_SHIFT CONFIG_MIPS_L1_CACHE_SHIFT #define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT) -#define __read_mostly __attribute__((__section__(".data..read_mostly"))) +#define __read_mostly __section(.data..read_mostly) #endif /* _ASM_CACHE_H */-- 2.23.0.rc1.153.gdeed80330f-goog
I'm not copied on the rest of the series so I'm not sure what your
expectations are about where this should be applied. Let me know if
you'd prefer this to go through mips-next, otherwise:
Acked-by: Paul Burton [off-list ref]
Thanks,
Paul