Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

On Tue, Aug 13, 2019 at 02:36:06PM +0200, Miguel Ojeda wrote:

On Tue, Aug 13, 2019 at 10:27 AM Will Deacon [off-list ref] wrote:

quoted

On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote:

quoted

GCC unescapes escaped string section names while Clang does not. Because
__section uses the `#` stringification operator for the section name, it
doesn't need to be escaped.

This antipattern was found with:
$ grep -e __section\(\" -e __section__\(\" -r

Reported-by: Sedat Dilek <redacted>
Suggested-by: Josh Poimboeuf <redacted>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
 arch/arm64/include/asm/cache.h     | 2 +-
 arch/arm64/kernel/smp_spin_table.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Does this fix a build issue, or is it just cosmetic or do we end up with
duplicate sections or something else?

This should be cosmetic -- basically we are trying to move all users
of current available __attribute__s in compiler_attributes.h to the
__attr forms. I am also adding (slowly) new attributes that are
already used but we don't have them yet in __attr form.

quoted

Happy to route it via arm64, just having trouble working out whether it's
5.3 material!

As you prefer! Those that are not taken by a maintainer I will pick up
and send via compiler-attributes.

I would go for 5.4, since there is no particular rush anyway.

Okey doke, I'll pick this one up for 5.4 then. Thanks for the explanation!

Will