Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h
From: Will Deacon <will@kernel.org>
Date: 2019-08-13 08:27:54
Also in:
bpf, linux-arm-kernel, lkml
Hi Nick, On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote:
GCC unescapes escaped string section names while Clang does not. Because __section uses the `#` stringification operator for the section name, it doesn't need to be escaped. This antipattern was found with: $ grep -e __section\(\" -e __section__\(\" -r Reported-by: Sedat Dilek <redacted> Suggested-by: Josh Poimboeuf <redacted> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- arch/arm64/include/asm/cache.h | 2 +- arch/arm64/kernel/smp_spin_table.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Does this fix a build issue, or is it just cosmetic or do we end up with duplicate sections or something else? Happy to route it via arm64, just having trouble working out whether it's 5.3 material! Will