Thread (44 messages) flat view 44 messages, 7 authors, 2019-08-21

Re: [PATCH net-next v2 2/9] net: macsec: move some definitions in a dedicated header

From: Igor Russkikh <hidden>
Date: 2019-08-10 12:19:43
Also in: lkml

Hi Antoine,

Overall good looking patchset, great!
+/**
+ * struct macsec_tx_sa - transmit secure association
+ * @active:
+ * @next_pn: packet number to use for the next packet
+ * @lock: protects next_pn manipulations
+ * @key: key structure
+ * @stats: per-SA stats
+ */
+struct macsec_tx_sa {
+	struct macsec_key key;
+	spinlock_t lock;
+	u32 next_pn;
+	refcount_t refcnt;
+	bool active;
+	bool offloaded;
I don't see this `offloaded` field being used anywhere. Is this needed?

Regards,
  Igor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help