Re: [PATCH net-next v2 4/9] net: introduce MACsec ops and add a reference in net_device
From: Jakub Kicinski <hidden>
Date: 2019-08-09 20:35:16
Also in:
lkml
On Thu, 8 Aug 2019 16:05:55 +0200, Antoine Tenart wrote:
quoted hunk ↗ jump to hunk
This patch introduces MACsec ops for drivers to support offloading MACsec operations. A reference to those ops is added in net_device. Signed-off-by: Antoine Tenart <redacted> --- include/linux/netdevice.h | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 88292953aa6f..59ff123d62e3 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h@@ -53,6 +53,7 @@ struct netpoll_info; struct device; struct phy_device; struct dsa_port; +struct macsec_context; struct sfp_bus; /* 802.11 specific */@@ -910,6 +911,29 @@ struct xfrmdev_ops { }; #endif +#if defined(CONFIG_MACSEC) +struct macsec_ops {
I think it'd be cleaner to have macsec_ops declared in macsec.h and forward declare macsec_ops rather than macsec_context.
quoted hunk ↗ jump to hunk
+ /* Device wide */ + int (*mdo_dev_open)(struct macsec_context *ctx); + int (*mdo_dev_stop)(struct macsec_context *ctx); + /* SecY */ + int (*mdo_add_secy)(struct macsec_context *ctx); + int (*mdo_upd_secy)(struct macsec_context *ctx); + int (*mdo_del_secy)(struct macsec_context *ctx); + /* Security channels */ + int (*mdo_add_rxsc)(struct macsec_context *ctx); + int (*mdo_upd_rxsc)(struct macsec_context *ctx); + int (*mdo_del_rxsc)(struct macsec_context *ctx); + /* Security associations */ + int (*mdo_add_rxsa)(struct macsec_context *ctx); + int (*mdo_upd_rxsa)(struct macsec_context *ctx); + int (*mdo_del_rxsa)(struct macsec_context *ctx); + int (*mdo_add_txsa)(struct macsec_context *ctx); + int (*mdo_upd_txsa)(struct macsec_context *ctx); + int (*mdo_del_txsa)(struct macsec_context *ctx); +}; +#endif + struct dev_ifalias { struct rcu_head rcuhead; char ifalias[];@@ -1755,6 +1779,8 @@ enum netdev_priv_flags { * * @wol_enabled: Wake-on-LAN is enabled * + * @macsec_ops: MACsec offloading ops + * * FIXME: cleanup struct net_device such that network protocol info * moves out. */@@ -2036,6 +2062,11 @@ struct net_device { struct lock_class_key *qdisc_running_key; bool proto_down; unsigned wol_enabled:1; + +#if IS_ENABLED(CONFIG_MACSEC) + /* MACsec management functions */ + const struct macsec_ops *macsec_ops; +#endif }; #define to_net_dev(d) container_of(d, struct net_device, dev)