Re: [PATCH net-next v2 0/9] net: macsec: initial support for hardware offloading
From: Antoine Tenart <hidden>
Date: 2019-08-09 11:40:56
Also in:
lkml
Hi Allan, On Fri, Aug 09, 2019 at 01:23:47PM +0200, Allan W. Nielsen wrote:
I have done a first read through of your patch and it looks good to me. The only thing which confused me is all the references to Ocelot. As far as I can see, this is a driver for the vsc8584 PHY in the Viper family. The Ocelot confusion is properly because you are developing it on an Ocelot board. But this is actually a modded board, the official PCB 120 and PCB123 has a different pin compatible PHY without MACsec. FYI: In the Viper family we have VSC8575, VSC8582, VSC8584, VSC8562 and VSC8564. VSC8575, does not have MACsec, but all other does, and they are binary compatible (it is the same die instantiated 2 or 4 times, with or without MACsec/SyncE). I beleive it is only the commit comments which needs to be addressed.
That's right, I mixed up Ocelot and the actual PHY names. I'll look for Ocelot references in the patches and I'll fix it in v3. Thanks for spotting this, Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com