Re: [PATCH RFC] net: dsa: mv88e6xxx: fully support SERDES on Topaz family

On Mon, 26 Aug 2019 14:28:09 -0400
Vivien Didelot [off-list ref] wrote:

Ask yourself what is the single task achieved by this function, and name this
operation accordingly. It seems to change the CMODE to be writable, only
supported by certain switch models right? So in addition to port_get_cmode
and port_set_cmode, you can add port_set_cmode_writable, and call it right
before or after port_set_cmode in mv88e6xxx_port_setup_mac.

Andrew's complaint was also about this function being called every time
cmode is to be changed. The cmode does need to be made writable only
once. In this sense it does make sense to put into into
mv88e6xxx_setup_port.

Also please address the last comment I made in v3 in the new series.

I shall.