Re: [PATCH net-next v4 6/6] net: dsa: mv88e6xxx: fully support SERDES on Topaz family
From: Marek Behun <hidden>
Date: 2019-08-26 17:52:25
On Mon, 26 Aug 2019 13:44:18 -0400 Vivien Didelot [off-list ref] wrote:
quoted
It can be done once at probe. At first I thought about doing this in setup_errata, but this is not an erratum. So shall I create a new method for this in chip operations structure? Something like port_additional_setup() ?No. Those "setup" or "config" functions are likely to do everything and become a mess, thus unmaintainable. Operations must be specific.
What about Andrew's complaint, then, abouth the two additional parameters?