Re: [PATCH net-next v4 3/6] net: dsa: mv88e6xxx: create serdes_get_lane chip operation
From: Andrew Lunn <andrew@lunn.ch>
Date: 2019-08-26 15:28:17
quoted hunk ↗ jump to hunk
-int mv88e6390x_serdes_get_lane(struct mv88e6xxx_chip *chip, int port) +int mv88e6390x_serdes_get_lane(struct mv88e6xxx_chip *chip, int port, s8 *lane) { u8 cmode_port9, cmode_port10, cmode_port;@@ -323,76 +320,80 @@ int mv88e6390x_serdes_get_lane(struct mv88e6xxx_chip *chip, int port) cmode_port10 = chip->ports[10].cmode; cmode_port = chip->ports[port].cmode; + *lane = -1; +
You could move that into mv88e8xxx_serdes_get_lane().
Otherwise
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew