Hi Florian,

I am grateful for the thorough review you made to the entire patchset.
It's nice to meet passionate people whom I can share ideas with.


On Tue, 26 Mar 2019 at 15:02, Florian Fainelli [off-list ref] wrote:

On 3/23/2019 8:23 PM, Vladimir Oltean wrote:

quoted

At this moment the following is supported:
* Link state management through phylib

Not a show stopper for now, and your implementation looks sane, though I
would recommend implementing phylink to be future proof, and especially
since you support SGMII.

I was not able to review everything deeply so:

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian

I don't think SGMII works at this point, with the current enablement.
When I send the first non-RFC patchset I think I'm going to completely
remove it (along with some other momentarily unused code). I'll add it
back when I can put my hands on a board where the SGMII interface is
actually routed - hopefully in a few weeks at most. Then I can also
rework the MAC adaptation to PHY portion to use phylink instead of
phylib, for "future-proofing".

Thank you!
-Vladimir