Re: [RFC PATCH net-next 06/13] net: dsa: Introduce driver for NXP SJA1105... | netdev

[RFC PATCH net-next 00/13] NXP SJA1105 DSA driver · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
[RFC PATCH net-next 02/13] net: dsa: Store vlan_filtering as a property of dsa_port · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 02/13] net: dsa: Store vlan_filtering as a property of dsa_port · Andrew Lunn <andrew@lunn.ch> · 2019-03-24
Re: [RFC PATCH net-next 02/13] net: dsa: Store vlan_filtering as a property of dsa_port · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-25
[RFC PATCH net-next 04/13] net: dsa: Call driver's setup callback after setting up its switchdev notifier · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 04/13] net: dsa: Call driver's setup callback after setting up its switchdev notifier · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-25
[RFC PATCH net-next 01/13] lib: Add support for generic packing operations · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 01/13] lib: Add support for generic packing operations · Richard Cochran <richardcochran@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 01/13] lib: Add support for generic packing operations · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 01/13] lib: Add support for generic packing operations · Richard Cochran <richardcochran@gmail.com> · 2019-03-26
[RFC PATCH net-next 05/13] net: dsa: Optional VLAN-based port separation for switches without tagging · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 05/13] net: dsa: Optional VLAN-based port separation for switches without tagging · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-26
[RFC PATCH net-next 03/13] net: dsa: Create a more convenient function for installing port VLANs · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 03/13] net: dsa: Create a more convenient function for installing port VLANs · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-25
Re: [RFC PATCH net-next 03/13] net: dsa: Create a more convenient function for installing port VLANs · Vladimir Oltean <olteanv@gmail.com> · 2019-03-27
[RFC PATCH net-next 08/13] net: dsa: sja1105: Add support for VLAN operations · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 08/13] net: dsa: sja1105: Add support for VLAN operations · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-26
[RFC PATCH net-next 10/13] net: dsa: sja1105: Add support for traffic through standalone ports · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 10/13] net: dsa: sja1105: Add support for traffic through standalone ports · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-26
Re: [RFC PATCH net-next 10/13] net: dsa: sja1105: Add support for traffic through standalone ports · Vladimir Oltean <olteanv@gmail.com> · 2019-03-26
Re: [RFC PATCH net-next 10/13] net: dsa: sja1105: Add support for traffic through standalone ports · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-26
Re: [RFC PATCH net-next 10/13] net: dsa: sja1105: Add support for traffic through standalone ports · Vladimir Oltean <olteanv@gmail.com> · 2019-03-26
Re: [RFC PATCH net-next 10/13] net: dsa: sja1105: Add support for traffic through standalone ports · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-26
[RFC PATCH net-next 13/13] dt-bindings: net: dsa: Add documentation for NXP SJA1105 driver · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 13/13] dt-bindings: net: dsa: Add documentation for NXP SJA1105 driver · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-26
Re: [RFC PATCH net-next 13/13] dt-bindings: net: dsa: Add documentation for NXP SJA1105 driver · Vladimir Oltean <olteanv@gmail.com> · 2019-03-26
[RFC PATCH net-next 06/13] net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 06/13] net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-26
Re: [RFC PATCH net-next 06/13] net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch · Vladimir Oltean <olteanv@gmail.com> · 2019-03-26
[RFC PATCH net-next 07/13] net: dsa: sja1105: Add support for FDB and MDB management · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 07/13] net: dsa: sja1105: Add support for FDB and MDB management · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-26
[RFC PATCH net-next 12/13] Documentation: networking: dsa: Add details about NXP SJA1105 driver · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 12/13] Documentation: networking: dsa: Add details about NXP SJA1105 driver · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-26
[RFC PATCH net-next 09/13] net: dsa: sja1105: Add support for ethtool port counters · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 09/13] net: dsa: sja1105: Add support for ethtool port counters · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-26
[RFC PATCH net-next 11/13] net: dsa: sja1105: Add support for Spanning Tree Protocol · Vladimir Oltean <olteanv@gmail.com> · 2019-03-24
Re: [RFC PATCH net-next 00/13] NXP SJA1105 DSA driver · Florian Fainelli <f.fainelli@gmail.com> · 2019-03-25
Re: [RFC PATCH net-next 00/13] NXP SJA1105 DSA driver · Vinicius Costa Gomes <vinicius.gomes@intel.com> · 2019-03-26
Re: [RFC PATCH net-next 00/13] NXP SJA1105 DSA driver · Vladimir Oltean <olteanv@gmail.com> · 2019-03-26

Re: [RFC PATCH net-next 06/13] net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2019-03-26 13:02:22


On 3/23/2019 8:23 PM, Vladimir Oltean wrote:

At this moment the following is supported:
* Link state management through phylib

Not a show stopper for now, and your implementation looks sane, though I
would recommend implementing phylink to be future proof, and especially
since you support SGMII.

I was not able to review everything deeply so:

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help