Re: [RFC PATCH net-next 09/13] net: dsa: sja1105: Add support for ethtool port counters
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2019-03-26 02:44:41
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2019-03-26 02:44:41
On 3/23/2019 8:23 PM, Vladimir Oltean wrote:
Signed-off-by: Vladimir Oltean <olteanv@gmail.com> ---
[snip]
+
+int sja1105_get_sset_count(struct dsa_switch *ds, int port, int sset)
+{
+ int count = ARRAY_SIZE(sja1105_port_stats);
+ struct sja1105_private *priv = ds->priv;There is a missing if (sset != ETH_SS_STATS) return here potentially. With that: Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian