-----Original Message-----
From: Richard Cochran [mailto:richardcochran@gmail.com]
Sent: Wednesday, October 31, 2018 7:40 AM
To: Miroslav Lichvar <redacted>
Cc: Keller, Jacob E <jacob.e.keller@intel.com>; netdev@vger.kernel.org; intel-wired-
lan@lists.osuosl.org
Subject: Re: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

On Mon, Oct 29, 2018 at 02:31:09PM +0100, Miroslav Lichvar wrote:

quoted

I think there could be a flag in ptp_system_timestamp, or a parameter
of gettimex64(), which would enable/disable reading of the system
clock.

I'm not a fan of functions that change their behavior based on flags
in their input parameters.

Thanks,
Richard

Neither am I. I do however want to find a solution that avoids having drivers needlessly duplicate almost the same functionality.

Thanks,
Jake