Thread (23 messages) 23 messages, 4 authors, 2018-11-01

RE: [RFC PATCH 0/4] More accurate PHC<->system clock synchronization

From: "Keller, Jacob E" <jacob.e.keller@intel.com>
Date: 2018-10-27 01:29:19
Also in: intel-wired-lan

-----Original Message-----
From: Miroslav Lichvar [mailto:mlichvar@redhat.com]
Sent: Friday, October 26, 2018 9:28 AM
To: netdev@vger.kernel.org
Cc: intel-wired-lan@lists.osuosl.org; Richard Cochran <richardcochran@gmail.com>;
Keller, Jacob E [off-list ref]; Miroslav Lichvar [off-list ref]
Subject: [RFC PATCH 0/4] More accurate PHC<->system clock synchronization
I read the whole series, and it looks good to me.

Acked-by: Jacob Keller <jacob.e.keller@intel.com>
There is some duplication of code in the igb and ixgbe drivers, which I
don't like very much, but I thought it's better than extending and
wrapping the existing functions like in the e1000e driver. Also, mixing
SYSTIM and "system time" in the code will probably be confusing.

I wasn't able to find a better name for the ioctl, the structures, and
the driver function. If anyone has suggestions, please let me know.
Hmm.. Yea, I don't really have better names either.
Miroslav Lichvar (4):
  ptp: add PTP_SYS_OFFSET_EXTENDED ioctl
  e1000e: add support for extended PHC gettime
  igb: add support for extended PHC gettime
  ixgbe: add support for extended PHC gettime

 drivers/net/ethernet/intel/e1000e/e1000.h    |  3 ++
 drivers/net/ethernet/intel/e1000e/netdev.c   | 48 +++++++++++++----
 drivers/net/ethernet/intel/e1000e/ptp.c      | 21 ++++++++
 drivers/net/ethernet/intel/igb/igb_ptp.c     | 43 +++++++++++++++
 drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 57 ++++++++++++++++++++
 drivers/ptp/ptp_chardev.c                    | 39 ++++++++++++++
 include/linux/ptp_clock_kernel.h             | 26 +++++++++
 include/uapi/linux/ptp_clock.h               | 12 +++++
 8 files changed, 239 insertions(+), 10 deletions(-)

--
2.17.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help