Thread (28 messages) 28 messages, 5 authors, 2018-07-29

Re: [PATCH 1/4] MIPS: lantiq: Do not enable IRQs in dma open

From: Hauke Mehrtens <hauke@hauke-m.de>
Date: 2018-07-24 06:37:15
Also in: linux-mips


On 07/24/2018 02:19 AM, Paul Burton wrote:
Hi Hauke,

On Sat, Jul 21, 2018 at 09:13:55PM +0200, Hauke Mehrtens wrote:
quoted
When a DMA channel is opened the IRQ should not get activated
automatically, this allows it to pull data out manually without the help
of interrupts. This is needed for a workaround in the vrx200 Ethernet
driver.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 arch/mips/lantiq/xway/dma.c        | 1 -
 drivers/net/ethernet/lantiq_etop.c | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
If you'd like this to go via the netdev tree to keep it with the rest of
the series:

    Acked-by: Paul Burton [off-list ref]
Thanks, I also prefer that this goes through netdev.
Though I'd be happier if we didn't have DMA code seemingly used only by
an ethernet driver in arch/mips/ :)
There are also some out of tree driver that use this DMA code. This
should probably be converted to a DMA channel driver but that is not
very high on my todo list.

Hauke
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help