Thread (26 messages) 26 messages, 4 authors, 2018-05-28

Re: [PATCH bpf-next 3/5] selftests/bpf: test_sockmap, fix test timeout

From: John Fastabend <john.fastabend@gmail.com>
Date: 2018-05-21 17:13:20

On 05/20/2018 10:15 PM, Prashant Bhole wrote:

On 5/19/2018 1:47 AM, John Fastabend wrote:
quoted
On 05/18/2018 12:17 AM, Prashant Bhole wrote:
quoted
In order to reduce runtime of tests, recently timout for select() call
was reduced from 1sec to 10usec. This was causing many tests failures.
It was caught with failure handling commits in this series.

Restoring the timeout from 10usec to 1sec

Fixes: a18fda1a62c3 ("bpf: reduce runtime of test_sockmap tests")
Signed-off-by: Prashant Bhole <redacted>
---
Whats the runtime for the entire test suite after this? I agree
I was probably to aggressive in setting this but on the other
hand I was trying to avoid letting the test run for minutes.
Currently any failure stops further tests.
So I made local change to force cork=0. With this change, it takes
around 60 seconds for all 648 tests. It will change after fixing cork
tests.

-Prashant

OK, lets see how long it takes with the cork tests fixed. Maybe if
the cork flag is set we should lower the timeout to 100us.

.John
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help