Re: [PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode
From: Prashant Bhole <hidden>
Date: 2018-05-21 05:15:49
From: Prashant Bhole <hidden>
Date: 2018-05-21 05:15:49
On 5/19/2018 1:45 AM, John Fastabend wrote:
On 05/18/2018 12:17 AM, Prashant Bhole wrote:quoted
In case of selftest mode, temporary cgroup environment is created but cgroup is not joined. It causes test failures. Fixed by joining the cgroup Fixes: 16962b2404ac ("bpf: sockmap, add selftests") Signed-off-by: Prashant Bhole <redacted> --Thanks, LGTM. Should this be the first patch in the series though? I wonder if after patch 1 if you would get failures without this patch.
Patch 1 fixes selftest mode as well as manual mode. This patch 2 is specifically for selftest mode, hence the sequence. - Prashant