Re: [PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode

[PATCH bpf-next 0/5] fix test_sockmap · Prashant Bhole <hidden> · 2018-05-18
[PATCH bpf-next 1/5] selftests/bpf: test_sockmap, check test failure · Prashant Bhole <hidden> · 2018-05-18
[PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode · Prashant Bhole <hidden> · 2018-05-18
Re: [PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode · John Fastabend <john.fastabend@gmail.com> · 2018-05-18
Re: [PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode · Prashant Bhole <hidden> · 2018-05-21
Re: [PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode · John Fastabend <john.fastabend@gmail.com> · 2018-05-21
[PATCH bpf-next 3/5] selftests/bpf: test_sockmap, fix test timeout · Prashant Bhole <hidden> · 2018-05-18
Re: [PATCH bpf-next 3/5] selftests/bpf: test_sockmap, fix test timeout · John Fastabend <john.fastabend@gmail.com> · 2018-05-18
Re: [PATCH bpf-next 3/5] selftests/bpf: test_sockmap, fix test timeout · Prashant Bhole <hidden> · 2018-05-21
Re: [PATCH bpf-next 3/5] selftests/bpf: test_sockmap, fix test timeout · John Fastabend <john.fastabend@gmail.com> · 2018-05-21
[PATCH bpf-next 4/5] selftests/bpf: test_sockmap, fix data verification · Prashant Bhole <hidden> · 2018-05-18
Re: [PATCH bpf-next 4/5] selftests/bpf: test_sockmap, fix data verification · John Fastabend <john.fastabend@gmail.com> · 2018-05-18
[PATCH bpf-next 5/5] selftests/bpf: test_sockmap, print additional test options · Prashant Bhole <hidden> · 2018-05-18
Re: [PATCH bpf-next 5/5] selftests/bpf: test_sockmap, print additional test options · John Fastabend <john.fastabend@gmail.com> · 2018-05-18
Re: [PATCH bpf-next 0/5] fix test_sockmap · John Fastabend <john.fastabend@gmail.com> · 2018-05-18
Re: [PATCH bpf-next 0/5] fix test_sockmap · Prashant Bhole <hidden> · 2018-05-21
Re: [PATCH bpf-next 0/5] fix test_sockmap · John Fastabend <john.fastabend@gmail.com> · 2018-05-21
Re: [PATCH bpf-next 0/5] fix test_sockmap · Prashant Bhole <hidden> · 2018-05-23
Re: [PATCH bpf-next 0/5] fix test_sockmap · Prashant Bhole <hidden> · 2018-05-24
Re: [PATCH bpf-next 0/5] fix test_sockmap · John Fastabend <john.fastabend@gmail.com> · 2018-05-24
Re: [PATCH bpf-next 0/5] fix test_sockmap · Prashant Bhole <hidden> · 2018-05-25
Re: [PATCH bpf-next 0/5] fix test_sockmap · John Fastabend <john.fastabend@gmail.com> · 2018-05-25
Re: [PATCH bpf-next 0/5] fix test_sockmap · Prashant Bhole <hidden> · 2018-05-28
Re: [PATCH bpf-next 0/5] fix test_sockmap · Shuah Khan <shuah@kernel.org> · 2018-05-18
Re: [PATCH bpf-next 0/5] fix test_sockmap · Daniel Borkmann <daniel@iogearbox.net> · 2018-05-18
Re: [PATCH bpf-next 0/5] fix test_sockmap · Prashant Bhole <hidden> · 2018-05-21

From: John Fastabend <john.fastabend@gmail.com>
Date: 2018-05-18 16:45:05

On 05/18/2018 12:17 AM, Prashant Bhole wrote:

In case of selftest mode, temporary cgroup environment is created but
cgroup is not joined. It causes test failures. Fixed by joining the
cgroup

Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
Signed-off-by: Prashant Bhole <redacted>
--

Thanks, LGTM. Should this be the first patch in the series though?
I wonder if after patch 1 if you would get failures without this
patch.

Acked-by: John Fastabend <john.fastabend@gmail.com>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help